Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit mypy issues #588

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix pre-commit mypy issues #588

merged 1 commit into from
Jan 16, 2024

Conversation

tomvothecoder
Copy link
Collaborator

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added the type: devops Testing, CI/CD, systems configuration label Jan 16, 2024
@tomvothecoder tomvothecoder self-assigned this Jan 16, 2024
@github-actions github-actions bot added the type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb624bd) 100.00% compared to head (1330b59) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1602      1602           
=========================================
  Hits          1602      1602

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder tomvothecoder marked this pull request as ready for review January 16, 2024 19:40
@tomvothecoder tomvothecoder merged commit fbf1db6 into main Jan 16, 2024
9 checks passed
@tomvothecoder tomvothecoder deleted the devops/587-fix-mypy branch January 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomvothecoder tomvothecoder

Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: devops Testing, CI/CD, systems configuration
Projects
xCDAT Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevOps]: Fix latest mypy pre-commit errors on main
1 participant
@tomvothecoder